Merge commit '61c34bb74ad275430fb8909f64fc18cd588fb943' into pipelines/run-20261111-1927-open-search-with-alt-slash-and-cmd-slash-f9f5
This commit is contained in:
@@ -21,3 +21,17 @@ Evidence:
|
||||
No browser fixture was run in this implementation stage; browser terminal
|
||||
fixture support and full-app rendered evidence remain for the appropriate
|
||||
review stage.
|
||||
|
||||
## Manager browser integration
|
||||
|
||||
Verified the merged full-app fixture with
|
||||
`chats=2&header=1&terminals=1&terminal=float` at 1800×1000. Floated the second
|
||||
chat, clicked the exposed Terminal content to focus it, then pressed Ctrl+Y.
|
||||
Before typing, the browser's active element was the chat's `TEXTAREA`, labelled
|
||||
`Work on demo`. Typing `Typed immediately after Ctrl+Y` appeared in that chat
|
||||
without another click; the chat was visibly above Terminal.
|
||||
|
||||
Inspected `06-typed.png`. Capture reports, semantics snapshots and screenshots
|
||||
are retained under run 369's `public/manager-integration-ctrl-y/`. This verifies
|
||||
the actual Terminal/Chat widgets and browser focus handoff with a fake gateway,
|
||||
not a live shell backend or native device installation.
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
# Material chat Cupertino cleanup
|
||||
|
||||
- Removed dead Material-only conversation helpers and the unused Cupertino icon
|
||||
metadata from the thread header; `ChatBarAction.cupertinoIcon` remains an
|
||||
optional ignored compatibility parameter for callers in other chat lanes.
|
||||
- Removed unused `cupertino` arguments from transcript bubbles and copy-button
|
||||
construction while preserving the existing Material widgets and behavior.
|
||||
- Focused UI states covered: transcript bubble color rendering, message layout,
|
||||
and chat thread view/header behavior.
|
||||
- Checks: `tool/memwatch/full.sh 'test/features/chat/ui/transcript/chat_bubble_color_test.dart test/features/chat/ui/transcript/chat_message_view_test.dart test/features/chat/conversation/chat_thread_view_test.dart'`
|
||||
— PASS (24 passed); `tool/analyze.sh` — clean.
|
||||
- No visual redesign or browser/device capture was needed: the edits remove
|
||||
unused parameters and alternate icon metadata without changing rendered
|
||||
Material controls, layout, focus, scrolling, or navigation behavior.
|
||||
@@ -0,0 +1,7 @@
|
||||
# Material chat and graph probes
|
||||
|
||||
- Removed Cupertino imports, host branches, and local style flags from the assigned chat and graph/stage-definition Dart probes.
|
||||
- Preserved Material scaffolds, dark/light themes, text scaling, fixture data, callbacks, and browser interaction states.
|
||||
- Focused watchdog tests: 39 passed across graph widgets and chat thread/composer coverage.
|
||||
- `tool/analyze.sh`: clean, 0 errors, 0 warnings.
|
||||
- Node syntax checks passed for the corresponding probe drivers. No browser capture was run; this cleanup does not alter intended Material rendering.
|
||||
@@ -0,0 +1,16 @@
|
||||
# Material-only feature surface cleanup
|
||||
|
||||
- Removed Cupertino imports and alternate glyph metadata from artifact viewer
|
||||
actions, fullscreen zoom controls, and viewer controls.
|
||||
- Made search, schedule-toolbar, and artifact fullscreen compatibility flags
|
||||
optional and ignored while retaining shared adaptive API arguments required
|
||||
by other lanes. Material icons are used for those required compatibility
|
||||
glyph parameters.
|
||||
- Focused checks: `tool/memwatch/full.sh` ran artifact actions/fullscreen and
|
||||
controls, search bar layout, schedule refresh, and template layout tests: 30
|
||||
passed, 0 failed.
|
||||
- `tool/analyze.sh`: clean.
|
||||
- No rendered behavior was intentionally changed; controls remain the existing
|
||||
Material widgets and layouts.
|
||||
- Remaining shared compatibility metadata/flags are outside this focused edit
|
||||
and should be removed only after all callers migrate during final integration.
|
||||
@@ -0,0 +1,14 @@
|
||||
# Material-only terminal and chat shell cleanup
|
||||
|
||||
- Removed Cupertino icon imports, alternate icon metadata, and ignored host
|
||||
flags from terminal and chat-shell widgets while retaining the existing
|
||||
Material controls and terminal keyboard/focus/resize behavior.
|
||||
- `TerminalSurface.cupertino` and `TerminalToggleButton.cupertino` remain
|
||||
optional ignored compatibility parameters for the application lane's
|
||||
existing `app_terminals.dart` callers; they have no rendering effect and are
|
||||
ready for removal after those callers migrate.
|
||||
- Focused check: `tool/memwatch/full.sh` with the nine terminal/chat-shell test
|
||||
paths, 52 passed, 0 failed, 0 skipped.
|
||||
- Analysis: `tool/analyze.sh` clean.
|
||||
- No visual redesign or capture was performed; the changed widgets continue to
|
||||
use the same Material palette, controls, layout, and semantics.
|
||||
@@ -0,0 +1,25 @@
|
||||
# Material startup and shell cleanup
|
||||
|
||||
- Consolidated application startup, onboarding, routing pages, connection
|
||||
states, Search, Templates, Schedules, and the navigation shell onto Material
|
||||
composition on every platform.
|
||||
- Kept legacy `cupertino` constructor arguments optional/ignored where callers
|
||||
still pass them; no Cupertino widgets or platform host selection remain in
|
||||
the changed application paths.
|
||||
- Focused watchdog command ran the mirrored application/routing/navigation and
|
||||
shell tests: 38 passed and 7 failed. The seven failures were teardown
|
||||
assertions for the pre-existing 15-second `LaunchUpdateChecker` timer in
|
||||
`PipelinesApp`; no Material cleanup assertion failed.
|
||||
- `tool/analyze.sh`: clean (exit 0).
|
||||
- No rendered capture was performed; this cleanup preserves the existing
|
||||
Material scaffold, bars, connection states, focus, and navigation semantics.
|
||||
|
||||
## Manager recovery
|
||||
|
||||
The navigation and template-wiring fixtures were inadvertently invoking native
|
||||
update plugins. They now explicitly disable updates, while dedicated startup
|
||||
update tests retain and exercise the real update-check behavior.
|
||||
|
||||
The focused routing, app, schedules, template-wiring, split-bar, startup-update
|
||||
check and startup-update-flow tests passed: 39 passed, zero failed. No production
|
||||
update behavior was changed to hide the teardown failures.
|
||||
Reference in New Issue
Block a user